[NFC] [MTE] add more tests for globals #113390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
|
@llvm/pr-subscribers-backend-aarch64 Author: Florian Mayer (fmayer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/113390.diff 1 Files Affected:
diff --git a/llvm/test/MC/AArch64/global-tagging.ll b/llvm/test/MC/AArch64/global-tagging.ll
index c8b3f52401dc11..75453e9bb62056 100644
--- a/llvm/test/MC/AArch64/global-tagging.ll
+++ b/llvm/test/MC/AArch64/global-tagging.ll
@@ -9,9 +9,12 @@
; RUN: llvm-mc -filetype=obj %t.S -triple=aarch64-linux-android31 -o %t.o
; RUN: llvm-readelf -r %t.o | FileCheck %s --check-prefix=CHECK-RELOCS
-; RUN: obj2yaml %t.o -o %t.yaml
-; RUN: FileCheck %s --input-file=%t.yaml --check-prefix=CHECK-YAML
+; RUN: obj2yaml %t.o -o %t.o.yaml
+; RUN: FileCheck %s --input-file=%t.o.yaml --check-prefix=CHECK-OYAML
; RUN: llvm-readelf -r %t.o | FileCheck %s --check-prefix=CHECK-RELOCS
+; RUN: ld.lld %t.o -o %t.so
+; RUN: obj2yaml %t.so -o %t.so.yaml
+; RUN: FileCheck %s --input-file=%t.so.yaml --check-prefix=CHECK-SOYAML
;; Check we don't create relocations referencing a section symbol for sanitize_memtag globals.
; CHECK-RELOCS: Relocation section '.rela.text' {{.*}} contains 4 entries:
@@ -27,19 +30,34 @@
; CHECK-RELOCS: R_AARCH64_NONE {{.*}} huge
; CHECK-RELOCS-NOT: specialcaselisted
-; CHECK-YAML: Sections:
-; CHECK-YAML: - Name: .rela.memtag.globals.static
-; CHECK-YAML-NOT: - Name:
-; CHECK-YAML: Relocations:
-; CHECK-YAML-NEXT: - Symbol: internal_four
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: - Symbol: four
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: - Symbol: sixteen
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: - Symbol: huge
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: -
+; CHECK-OYAML: Sections:
+; CHECK-OYAML: - Name: .rela.memtag.globals.static
+; CHECK-OYAML-NOT: - Name:
+; CHECK-OYAML: Relocations:
+; CHECK-OYAML-NEXT: - Symbol: internal_four
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: - Symbol: four
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: - Symbol: sixteen
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: - Symbol: huge
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: -
+
+;; Value: 0x{{.*}}0 checks for 16-alignment of address
+; CHECK-SOYAML: Symbols:
+; CHECK-SOYAML: - Name: internal_four
+; CHECK-SOYAML: Value: 0x{{.*}}0
+; CHECK-SOYAML: - Name: four
+; CHECK-SOYAML: Value: 0x{{.*}}0
+; CHECK-SOYAML: - Name: sixteen
+; CHECK-SOYAML: Value: 0x{{.*}}0
+; CHECK-SOYAML: - Name: huge
+; CHECK-SOYAML: Value: 0x{{.*}}0
+;; At least as currently laid out, specialcaselisted gets put adjacient to a
+;; tagged global, so it also has to be aligned to the next granule.
+; CHECK-SOYAML: - Name: specialcaselisted
+; CHECK-SOYAML: Value: 0x{{.*}}0
; CHECK-ASM: .memtag internal_four
; CHECK-ASM .p2align 4
|
|
@llvm/pr-subscribers-mc Author: Florian Mayer (fmayer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/113390.diff 1 Files Affected:
diff --git a/llvm/test/MC/AArch64/global-tagging.ll b/llvm/test/MC/AArch64/global-tagging.ll
index c8b3f52401dc11..75453e9bb62056 100644
--- a/llvm/test/MC/AArch64/global-tagging.ll
+++ b/llvm/test/MC/AArch64/global-tagging.ll
@@ -9,9 +9,12 @@
; RUN: llvm-mc -filetype=obj %t.S -triple=aarch64-linux-android31 -o %t.o
; RUN: llvm-readelf -r %t.o | FileCheck %s --check-prefix=CHECK-RELOCS
-; RUN: obj2yaml %t.o -o %t.yaml
-; RUN: FileCheck %s --input-file=%t.yaml --check-prefix=CHECK-YAML
+; RUN: obj2yaml %t.o -o %t.o.yaml
+; RUN: FileCheck %s --input-file=%t.o.yaml --check-prefix=CHECK-OYAML
; RUN: llvm-readelf -r %t.o | FileCheck %s --check-prefix=CHECK-RELOCS
+; RUN: ld.lld %t.o -o %t.so
+; RUN: obj2yaml %t.so -o %t.so.yaml
+; RUN: FileCheck %s --input-file=%t.so.yaml --check-prefix=CHECK-SOYAML
;; Check we don't create relocations referencing a section symbol for sanitize_memtag globals.
; CHECK-RELOCS: Relocation section '.rela.text' {{.*}} contains 4 entries:
@@ -27,19 +30,34 @@
; CHECK-RELOCS: R_AARCH64_NONE {{.*}} huge
; CHECK-RELOCS-NOT: specialcaselisted
-; CHECK-YAML: Sections:
-; CHECK-YAML: - Name: .rela.memtag.globals.static
-; CHECK-YAML-NOT: - Name:
-; CHECK-YAML: Relocations:
-; CHECK-YAML-NEXT: - Symbol: internal_four
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: - Symbol: four
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: - Symbol: sixteen
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: - Symbol: huge
-; CHECK-YAML-NEXT: Type: R_AARCH64_NONE
-; CHECK-YAML-NEXT: -
+; CHECK-OYAML: Sections:
+; CHECK-OYAML: - Name: .rela.memtag.globals.static
+; CHECK-OYAML-NOT: - Name:
+; CHECK-OYAML: Relocations:
+; CHECK-OYAML-NEXT: - Symbol: internal_four
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: - Symbol: four
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: - Symbol: sixteen
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: - Symbol: huge
+; CHECK-OYAML-NEXT: Type: R_AARCH64_NONE
+; CHECK-OYAML-NEXT: -
+
+;; Value: 0x{{.*}}0 checks for 16-alignment of address
+; CHECK-SOYAML: Symbols:
+; CHECK-SOYAML: - Name: internal_four
+; CHECK-SOYAML: Value: 0x{{.*}}0
+; CHECK-SOYAML: - Name: four
+; CHECK-SOYAML: Value: 0x{{.*}}0
+; CHECK-SOYAML: - Name: sixteen
+; CHECK-SOYAML: Value: 0x{{.*}}0
+; CHECK-SOYAML: - Name: huge
+; CHECK-SOYAML: Value: 0x{{.*}}0
+;; At least as currently laid out, specialcaselisted gets put adjacient to a
+;; tagged global, so it also has to be aligned to the next granule.
+; CHECK-SOYAML: - Name: specialcaselisted
+; CHECK-SOYAML: Value: 0x{{.*}}0
; CHECK-ASM: .memtag internal_four
; CHECK-ASM .p2align 4
|
Created using spr 1.3.4 [skip ci]
fmayer
changed the base branch from
users/fmayer/spr/main.nfc-mte-add-more-tests-for-globals
to
main
pcc
reviewed
Oct 28, 2024
| ; RUN: obj2yaml %t.o -o %t.o.yaml | ||
| ; RUN: FileCheck %s --input-file=%t.o.yaml --check-prefix=CHECK-OYAML | ||
| ; RUN: llvm-readelf -r %t.o | FileCheck %s --check-prefix=CHECK-RELOCS | ||
| ; RUN: ld.lld %t.o -o %t.so |
There was a problem hiding this comment.
I don't think LLD is built as part of check-llvm so I would expect this to fail unless a new-enough LLD happens to be on $PATH. The new test probably needs to be added to LLD instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.